UltraVNC

@ThomasLevering: All your comments/requests/fixes since several years have been added?
Please specified if one has been forgotten.


Viewer, this was my text (todo)
// cy = rcWnd.bottom - rcWnd.top; // not OK, toDo size wrong after dpichange
on my computer this is working.
1x 4k Monitor on 200 ...

The Option vncviewer.exe /h is not working -> exception "buffer to small"

VNCOptions.cpp Line 1352

void VNCOptions::ShowUsage(LPTSTR info) {
TCHAR msg[1024]


and
win32_helpers.cpp Line 160
bool yesUVNCMessageBox(HINSTANCE hInst, HWND m_hWnd, char* body, char* szHeader, int icon)
{
wchar_t w ...

Viewer:
ClientConnection.cpp Line 618

if (osvi.dwMajorVersion >= 6 && osvi.dwMinorVersion >= 3)

this is always 6.2
result in m_Dpi = 96

The Scaling of the boarder is wrong if other DPI then 96 is used

Viewer
-help, -? or -h

is not working

Hello,

i found a small Problem.
If i save a Connection to *.vnc File with Password
The Password is not used if the first crypted char in the *.vnc File ist "00"

[connection]
..
password=0012345678901234

is not used


PS: I Generate a other Password

Thank you

x64\winvnc64.exe is 1.3.9.1 in zip (is this winvncipV6.exe?) and the timestamp is from 24.04.2022
all other files are 1.3.8.2

Viewer

Problem:
m_Dpi = GetDeviceCaps(GetDC(m_hwndMain), LOGPIXELSX);
sometimes give the wrong DPI
Laptop with 4k Boot, connect to dock(disconnet primary 4k and connect 2k display)
then GetDeviceCaps deliver 192 DPI (only 96 DPI Monitor connected)

Solution:
change GetDeviceCaps to ...

SkyBeam wrote:reverse connect/repeater

I Use Repeater with encryption plugin and password -> no Warning

One Solution:
click Thrust and write this to "IP".vnc File

FullScreenTitleBar

Resolved (Only with Multimonitor with different DPI)
add "::SetWindowRgn" after DPI change

and save hLastMonitor TitleBar on wrong Monitor

i hope the last changes from me :)

add option only in Ini
1.
AutoScalingLimit=1
-> If Windows Scale/Dpi is 150% Autosize is max 150%
-> If Windows Scale/Dpi is 200% Autosize is max 200%
per Monitor

2.
BlockSameMouse=1
if the Server is not UltraVnc and more then One Client. Block MouseEvents with ...

Downloaded, and Test OK

the testrect is for Autosize

test
Download "UltraVNC-development.zip" from Git
unzip in new folder
change files from "vnc 2021 08 29.zip"

Open "vncviewer_vs2017.sln"
not Autoupgrade
mark all and change to 10.0 and v142

All is working.
(Only Debug x64 not -> LNK1104 Datei "zlibstat.lib" ..)

VS2017 not installed

compiled exe with all patches (tyanO and my)

https://1drv.ms/f/s!AkdsiVHAVCeBhjFMuxmAGxOAqLdT

1.
FullScreenTitleBar Is not in dev12 and not in Git (changed Files in my Onedrive)
2.
Toolbar is the old
3.
many changes are with >=2 Monitors and different DPI
4.
Autosize changed.
New setting „Even“
Try scale 200% and enable/disable „scale to window“ to see difference
I use Autosize Even, if move ...

Next
FullScreenTitleBar
changed files in my Onedrive

the size of the FullScreenTitleBar changes with DPI change

I found the Bug
Send SendFullFramebufferUpdateRequest On DPI change before running -> empty picture
I add Autoscaling even in the old Options Dialog

https://1drv.ms/f/s!AkdsiVHAVCeBhjFMuxmAGxOAqLdT

wait with release, i found a problem

merge with git code
Now Autosize scale is OK (no Border, biggest possible window)

Faster and better result for other then 100,200,300% is to use "scale to window" (directX)
Autosize is working with directX in window mode too.

toDo
keep aspect ratio for Fullscreen in directX (Only if Autosize?)
GUI ...

New Viewer Exe in Onedrive

New Option:
Not in GUI, only Inifile

if AutoScalingEven=1
AutoScaling only scale to 100,200 or 300%

For other Scaling "Scale to Window" is faster

options.vnc

[options]
AutoScaling=1
AutoScalingEven=1


Other Fix AutoScaling no Boarder in calculation if Fullscreen ...

Viewer

I the connection is lost. The Restore/ConnectionLost Dialog is on a Other Monitor.
if click "Close" in this Dialog, the Dialog is Closed and the connection is restored -> OK
if you only see the window of the client connection and close the clientconnection window. The Dialog on the Other ...

Remove from Git ?

vncviewer_VC2017.vcxproj
<Manifest>
<EnableDpiAwareness>PerMonitorHighDPIAware</EnableDpiAwareness>
</Manifest>

See Picture in Onedrive: "SetStretchBltMode 1BLACKONWHITE 2COLORONCOLOR 3HALFTONE .png"

Only If Scaling is 200% or 300%, the Result is better if simply double the pixel


ClientConnection.cpp Line 5022

else
{

int n = m_opts.m_scale_num;
int d = m_opts.m_scale_den;
int m = n % d;
if (m == 0 ...

I Download from Git
don´t upgrade (I have Visual Studio 2019)
manualy select Windows SDK 10.0 (newest)
Plattformtoolset v142
Kompile and per Monitor v1 is active

Disable Manifesttool/DPI in Settings and per Monitor v2 is active

with your new exe, per Monitor v1 is active



<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<assembly xmlns="urn:schemas-microsoft-com:asm.v1" manifestVersion="1.0">
<dependency>
<dependentAssembly>
<assemblyIdentity type="win32" name="Microsoft.Windows.Common-Controls" version="6.0.0 ...

Check with this Tool

https://docs.microsoft.com/en-us/sysinternals/downloads/sigcheck
sigcheck64.exe -m "vncviewer.exe"


<?xml version='1.0' encoding='UTF-8' standalone='yes'?>
<assembly xmlns='urn:schemas-microsoft-com:asm.v1' manifestVersion='1.0'>
<trustInfo xmlns="urn:schemas-microsoft-com ...

with your exe, see Logfile (the Window is very small)

Time to use the actual WindowsSDK ?


Logfile

...
Geometry 3840 x 1080 depth 24
Screen work area is 5760 x 80
Reset keyboard for first use
Flush dead key gives: 1 character(s): 0x0020 ( )
Clipboard changed
Ignore Clipboard while initializing ...

Thank you,

Is "vncviewer.cpp" not Updated? DPI per Monitor v2 is not active

https://1drv.ms/f/s!AkdsiVHAVCeBhjFMuxmAGxOAqLdT

Uploaded 2 Pictures to see difference of dpi aware

Update Files

move window to screen with other dpi:
NoFlicker -> SizeWindow if Window is 100% on other monitor
Autosize is working

ClientConnection.cpp add restoreScreenPosition

case ID_CONN_ABOUT:
_this->ShowConnInfo();
return 0;

case ID_FULLSCREEN: // CTRL+ALT+F12
_this->SetFullScreenMode(!_this->InFullScreenMode());
if (!_this->InFullScreenMode())
_this->restoreScreenPosition();
return 0;

case ID_VIEWONLYTOGGLE ...

Updated

AdjustWindowRectEx change to AdjustWindowRectExForDpi (if Windows10)

void ClientConnection::saveScreenPosition()
sometimes save, after the window is maximized

later i see not all ok with CTRL+ALT+F12 (Restore not on Last Position)

to do FullScreenTitleBar painting font after change dpi ...