MSLogonACL cannot import/export localized accounts

[redge]

If an acl file specifies accounts whose name contains national letters, MSLogonACL cannot import such permissions (it reports "Garbled-Account-Name: SID not valid."). The same applies to export: if you specify such an account using the UI and then try to export the ACL, you get the text file with garbled account names, and this file cannot be imported either. This applies to unicode version of MSLogonACL (non-unicode version untested, may work properly).

This is fixed by the following patch:
[syntax="c"]
*** UltraVNC/winvnc/ms-logon/MSLogonACL/MSLogonACL.cpp Sun Feb 17 02:04:21 2008
--- UltraVNC/winvnc/ms-logon/MSLogonACL/MSLogonACL.cpp Tue May 25 14:55:07 2010
***************
*** 19,24 ****
--- 19,25 ----
// If the source code for the program is not available from the place from
// which you received this file, check
// http://ultravnc.sourceforge.net/
+ #include <locale.h>
#include <wchar.h>
#include <tchar.h>
#include "MSLogonACL.h"
***************
*** 28,33 ****
--- 29,35 ----

int _tmain(int argc, TCHAR *argv[])
{
+ setlocale( LC_ALL, "" );
bool append = false;
int rc = 1;
[/syntax]

Moderated by redge at 2011-01-06 23:40:

replaced code by syntax=c

[Mr13]

Would it be patched in official branch?

With new version I still get for localized Administrators group:
allow 0x00000003 BUILTIN\??????????????

[redge]

requested to Rudi to apply the patch asap to uvnc 1.0.9.5.1
hope it apply but you need to test and feedback
thank you

[mikekaganski]

It was commited by Rudi right after the last stable version was released.
However, this is just a partial patch, that will cover most, but not all, cases. E.g., it will not be able to handle cases when there are accounts that consist of non-english AND non-current-user-locale characters. The only way to handle this is to rewrite the code to use Unicode. It must be done in MSLogonACL as well as in the authSSP (and thus change the UVNC MSLogon protocol to transmit Unicode).

[redge]

did you try enable japanese keyboard at vncviewer and winvnc ... options or this not effect anything with mslogon ?

normally uvnc 2.0.x should be full unicode and backward compatible.
standby now for bug fix to uvnc 1.0.9.5.1
adzm developer working for unicode as priority for next major version for non english people and non latin keyboard

[Mr13]

Ver 1.0.9.6 didn't help, still getting "???????".
There's also one more decision is to add support for SIDs in number format.

PS Is 2.0 stable? And where to get it?

[redge]

have a look at uvnc 1.0.9.6.1
user YY from Taiwan use MS Logon

http://forum.ultravnc.info/viewtopic.php?f=54&t=27951
files
http://www.uvnc.eu/download/10961/

uvnc 2.0, not yet started, next version 1.0.9.7 with multi monitor fix and some others feature,
shame fix of multi monitor NOT include to 1.0.9.6.1, hope would be honored.
should not effect to all other code, seperate code.

[Mr13]

Still no luck - I didn't find info that YY used working MSLogon and in supplied link with fresh files contain only server program.

[redge]

Mr13
sorry, my mistake
i'm confusing export/import mslogon with mslogon log on