MSLogonACL cannot import/export localized accounts

Should you have problems with the MS logon plugin, here's the place to look for help or report issues.

MSLogonACL cannot import/export localized accounts

Postby mikekaganski » 2010-05-25 04:22

If an acl file specifies accounts whose name contains national letters, MSLogonACL cannot import such permissions (it reports "Garbled-Account-Name: SID not valid."). The same applies to export: if you specify such an account using the UI and then try to export the ACL, you get the text file with garbled account names, and this file cannot be imported either. This applies to unicode version of MSLogonACL (non-unicode version untested, may work properly).

This is fixed by the following patch:
[syntax="c"]
*** UltraVNC/winvnc/ms-logon/MSLogonACL/MSLogonACL.cpp Sun Feb 17 02:04:21 2008
--- UltraVNC/winvnc/ms-logon/MSLogonACL/MSLogonACL.cpp Tue May 25 14:55:07 2010
***************
*** 19,24 ****
--- 19,25 ----
// If the source code for the program is not available from the place from
// which you received this file, check
// http://ultravnc.sourceforge.net/
+ #include <locale.h>
#include <wchar.h>
#include <tchar.h>
#include "MSLogonACL.h"
***************
*** 28,33 ****
--- 29,35 ----

int _tmain(int argc, TCHAR *argv[])
{
+ setlocale( LC_ALL, "" );
bool append = false;
int rc = 1;
[/syntax]
Moderated by redge at 2011-01-06 23:40:
replaced code by syntax=c
Last edited by mikekaganski on 2011-01-06 23:40, edited 1 time in total.
mikekaganski
 
Posts: 4
Joined: 2010-03-30 23:02

Re: MSLogonACL cannot import/export localized accounts

Postby Mr13 » 2011-01-25 03:59

Would it be patched in official branch?

With new version I still get for localized Administrators group:
allow 0x00000003 BUILTIN\??????????????
Last edited by Mr13 on 2011-01-25 04:42, edited 1 time in total.
Mr13
 
Posts: 3
Joined: 2011-01-25 03:50

Re: MSLogonACL cannot import/export localized accounts

Postby redge » 2011-01-26 00:52

requested to Rudi to apply the patch asap to uvnc 1.0.9.5.1 :-)
hope it apply but you need to test and feedback :-)
thank you
UltraVNC 1.0.9.6.1 (built 20110518)
OS Win: xp home + vista business + 7 home
only experienced user, not developer
redge
Super-Mod
Super-Mod
 
Posts: 6815
Joined: 2004-07-03 17:05
Location: Switzerland - Geneva

Re: MSLogonACL cannot import/export localized accounts

Postby mikekaganski » 2011-01-26 02:06

It was commited by Rudi right after the last stable version was released.
However, this is just a partial patch, that will cover most, but not all, cases. E.g., it will not be able to handle cases when there are accounts that consist of non-english AND non-current-user-locale characters. The only way to handle this is to rewrite the code to use Unicode. It must be done in MSLogonACL as well as in the authSSP (and thus change the UVNC MSLogon protocol to transmit Unicode).
mikekaganski
 
Posts: 4
Joined: 2010-03-30 23:02

Re: MSLogonACL cannot import/export localized accounts

Postby redge » 2011-01-26 02:43

did you try enable japanese keyboard at vncviewer and winvnc ... options or this not effect anything with mslogon ?

normally uvnc 2.0.x should be full unicode and backward compatible.
standby now for bug fix to uvnc 1.0.9.5.1
adzm developer working for unicode as priority for next major version for non english people and non latin keyboard :-)
UltraVNC 1.0.9.6.1 (built 20110518)
OS Win: xp home + vista business + 7 home
only experienced user, not developer
redge
Super-Mod
Super-Mod
 
Posts: 6815
Joined: 2004-07-03 17:05
Location: Switzerland - Geneva

Re: MSLogonACL cannot import/export localized accounts

Postby Mr13 » 2011-05-06 08:10

Ver 1.0.9.6 didn't help, still getting "???????".
There's also one more decision is to add support for SIDs in number format.

PS Is 2.0 stable? And where to get it?
Mr13
 
Posts: 3
Joined: 2011-01-25 03:50

Re: MSLogonACL cannot import/export localized accounts

Postby redge » 2011-05-08 20:01

have a look at uvnc 1.0.9.6.1
user YY from Taiwan use MS Logon

http://forum.ultravnc.info/viewtopic.php?f=54&t=27951
files
http://www.uvnc.eu/download/10961/

uvnc 2.0, not yet started, next version 1.0.9.7 with multi monitor fix and some others feature,
shame fix of multi monitor NOT include to 1.0.9.6.1, hope would be honored.
should not effect to all other code, seperate code.
UltraVNC 1.0.9.6.1 (built 20110518)
OS Win: xp home + vista business + 7 home
only experienced user, not developer
redge
Super-Mod
Super-Mod
 
Posts: 6815
Joined: 2004-07-03 17:05
Location: Switzerland - Geneva

Re: MSLogonACL cannot import/export localized accounts

Postby Mr13 » 2011-05-19 04:11

Still no luck - I didn't find info that YY used working MSLogon and in supplied link with fresh files contain only server program.
Mr13
 
Posts: 3
Joined: 2011-01-25 03:50

Re: MSLogonACL cannot import/export localized accounts

Postby redge » 2011-05-31 00:37

Mr13
sorry, my mistake
i'm confusing export/import mslogon with mslogon log on
UltraVNC 1.0.9.6.1 (built 20110518)
OS Win: xp home + vista business + 7 home
only experienced user, not developer
redge
Super-Mod
Super-Mod
 
Posts: 6815
Joined: 2004-07-03 17:05
Location: Switzerland - Geneva


Return to MS logon plugin

Who is online

Users browsing this forum: No registered users and 1 guest

cron